Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix xvc file track memory issue #260

Merged
merged 262 commits into from
Sep 9, 2024
Merged

Fix xvc file track memory issue #260

merged 262 commits into from
Sep 9, 2024

Conversation

iesahin
Copy link
Owner

@iesahin iesahin commented Aug 5, 2024

  • Bump dependencies
  • Replace globset with fast-glob for memory usage
  • Remove --details option from xvc check-ignore
  • Fixed xvc check-ignore to work with supplied paths
  • Fixed loading store targets from xvc file list
  • Directory targets in various commands doesn't require / at the end when they only exist in the cache
  • Removed some duplicate tests from ignore
  • Minio tests now use mc instead of s3cmd

Copy link

codecov bot commented Sep 9, 2024

Codecov Report

Attention: Patch coverage is 90.51546% with 46 lines in your changes missing coverage. Please review.

Project coverage is 72.75%. Comparing base (3a0735d) to head (483cbe7).
Report is 19 commits behind head on main.

Files with missing lines Patch % Lines
file/src/common/mod.rs 83.82% 11 Missing ⚠️
walker/src/pattern.rs 91.35% 7 Missing ⚠️
walker/src/walk_parallel.rs 90.41% 7 Missing ⚠️
lib/src/git.rs 0.00% 6 Missing ⚠️
walker/src/walk_serial.rs 86.66% 4 Missing ⚠️
core/src/check_ignore/mod.rs 93.10% 2 Missing ⚠️
core/src/util/git.rs 83.33% 2 Missing ⚠️
core/src/util/xvcignore.rs 86.66% 2 Missing ⚠️
lib/src/cli/mod.rs 71.42% 2 Missing ⚠️
walker/src/lib.rs 96.22% 2 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #260      +/-   ##
==========================================
+ Coverage   71.51%   72.75%   +1.24%     
==========================================
  Files         122      124       +2     
  Lines       11707    11674      -33     
==========================================
+ Hits         8372     8494     +122     
+ Misses       3335     3180     -155     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iesahin iesahin merged commit 942dc74 into main Sep 9, 2024
11 checks passed
@iesahin iesahin deleted the develop branch September 9, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant